aprantl added inline comments.
================
Comment at: lib/Bitcode/Reader/MetadataLoader.cpp:1684
+ HasFile ? getMDOrNull(Record[6]) : nullptr,
+ HasFile ? Record[4] : 0, getMDString(Record[5]))),
NextMetadataNo);
----------------
probinson wrote:
> That's a nice touch.
That was the best "upgrade" I could come up with for reliably dealing with the
old format. There is an assertion in DIBuilder that discourages creating new
nodes with a location with a line but no file. We could upgrade that to a
verifier check if we want to.
https://reviews.llvm.org/D35583
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
