jroelofs added inline comments.
================
Comment at: test/lit.cfg:36
+else:
+ lit_config.fatal('Could not find libcxx test directory for test imports'
+ ' in: %s' % libcxx_test_src_root)
----------------
manojgupta wrote:
> jroelofs wrote:
> > manojgupta wrote:
> > > I do not have libcxx checked out since I am want to use only compiler-rt
> > > + libunwind to replace libgcc_s. This libcxx dependency breaks this
> > > testing.
> > This only requires that you check it out, not that you build it. Note that
> > libcxxabi has the same constraint.
> Checking out libcxx should not be a requirement since libunwind should be
> usable independently on libcxx.
> Not sure if it can be compared to libcxxabi, since most people working on
> libcxx/libcxxabi will checkout both libcxx and libcxxabi.
The code duplication required to give you what you want is not worth it. When
the monorepo happens, you won't have a choice but to check both out... if this
was a bug report, I'd close it "WONTFIX".
https://reviews.llvm.org/D35038
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
