github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h,c --
clang/lib/Basic/Targets/X86.cpp compiler-rt/lib/builtins/cpu_model/x86.c
llvm/include/llvm/TargetParser/X86TargetParser.h
llvm/lib/TargetParser/X86TargetParser.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/lib/Basic/Targets/X86.cpp b/clang/lib/Basic/Targets/X86.cpp
index 30970f5d9..6df9fe648 100644
--- a/clang/lib/Basic/Targets/X86.cpp
+++ b/clang/lib/Basic/Targets/X86.cpp
@@ -1309,7 +1309,7 @@ bool X86TargetInfo::validateCpuSupports(StringRef
FeatureStr) const {
static llvm::X86::ProcessorFeatures getFeature(StringRef Name) {
return llvm::StringSwitch<llvm::X86::ProcessorFeatures>(Name)
-#define X86_FEATURE_COMPAT(ENUM, STR, PRIORITY, ABI_VALUE)
\
+#define X86_FEATURE_COMPAT(ENUM, STR, PRIORITY, ABI_VALUE)
\
.Case(STR, llvm::X86::FEATURE_##ENUM)
#include "llvm/TargetParser/X86TargetParser.def"
diff --git a/compiler-rt/lib/builtins/cpu_model/x86.c
b/compiler-rt/lib/builtins/cpu_model/x86.c
index 4a0deb8ea..609cb8791 100644
--- a/compiler-rt/lib/builtins/cpu_model/x86.c
+++ b/compiler-rt/lib/builtins/cpu_model/x86.c
@@ -1087,15 +1087,16 @@ static void getAvailableFeatures(unsigned ECX, unsigned
EDX, unsigned MaxLeaf,
if (HasLeafD && ((EAX >> 3) & 1) && HasAVXSave)
setFeature(FEATURE_XSAVES);
- bool HasLeaf1E = MaxLevel >= 0x1e && !getX86CpuIDAndInfoEx(0x1e, 0x1, &EAX,
&EBX, &ECX, &EDX);
+ bool HasLeaf1E = MaxLevel >= 0x1e &&
+ !getX86CpuIDAndInfoEx(0x1e, 0x1, &EAX, &EBX, &ECX, &EDX);
if (HasLeaf1E && (EAX & 0x10))
- setFeature(FEATURE_AMX_FP8);
+ setFeature(FEATURE_AMX_FP8);
if (HasLeaf1E && (EAX & 0x40))
- setFeature(FEATURE_AMX_TF32);
- if (HasLeaf1E && (EAX & 0x80))
- setFeature(FEATURE_AMX_AVX512);
+ setFeature(FEATURE_AMX_TF32);
+ if (HasLeaf1E && (EAX & 0x80))
+ setFeature(FEATURE_AMX_AVX512);
if (HasLeaf1E && (EAX & 0x100))
- setFeature(FEATURE_AMX_MOVRS);
+ setFeature(FEATURE_AMX_MOVRS);
bool HasLeaf24 =
MaxLevel >= 0x24 && !getX86CpuIDAndInfo(0x24, &EAX, &EBX, &ECX, &EDX);
diff --git a/llvm/lib/TargetParser/X86TargetParser.cpp
b/llvm/lib/TargetParser/X86TargetParser.cpp
index 4353560e8..188235bb9 100644
--- a/llvm/lib/TargetParser/X86TargetParser.cpp
+++ b/llvm/lib/TargetParser/X86TargetParser.cpp
@@ -558,7 +558,7 @@ constexpr FeatureBitset ImpliedFeaturesLVI_CFI = {};
constexpr FeatureBitset ImpliedFeaturesLVI_LOAD_HARDENING = {};
constexpr FeatureBitset ImpliedFeaturesX86_64_BASELINE = {};
constexpr FeatureBitset ImpliedFeaturesX86_64_V2 = {};
-constexpr FeatureBitset ImpliedFeaturesX86_64_V3 = {};
+constexpr FeatureBitset ImpliedFeaturesX86_64_V3 = {};
constexpr FeatureBitset ImpliedFeaturesX86_64_V4 = {};
// XSAVE features are dependent on basic XSAVE.
@@ -663,7 +663,10 @@ constexpr FeatureBitset ImpliedFeaturesNF = {};
constexpr FeatureBitset ImpliedFeaturesCF = {};
constexpr FeatureBitset ImpliedFeaturesZU = {};
-constexpr FeatureBitset ImpliedFeaturesAPXF = ImpliedFeaturesEGPR |
ImpliedFeaturesPush2Pop2 | ImpliedFeaturesPPX | ImpliedFeaturesNDD |
ImpliedFeaturesCCMP | ImpliedFeaturesNF | ImpliedFeaturesCF | ImpliedFeaturesZU;
+constexpr FeatureBitset ImpliedFeaturesAPXF =
+ ImpliedFeaturesEGPR | ImpliedFeaturesPush2Pop2 | ImpliedFeaturesPPX |
+ ImpliedFeaturesNDD | ImpliedFeaturesCCMP | ImpliedFeaturesNF |
+ ImpliedFeaturesCF | ImpliedFeaturesZU;
constexpr FeatureBitset ImpliedFeaturesMOVRS = {};
@@ -767,8 +770,7 @@ llvm::X86::getCpuSupportsMask(ArrayRef<StringRef>
FeatureStrs) {
std::array<uint32_t, 4> FeatureMask{};
for (StringRef FeatureStr : FeatureStrs) {
unsigned Feature = StringSwitch<unsigned>(FeatureStr)
-#define X86_FEATURE_COMPAT(ENUM, STR, PRIORITY, ABI_VALUE)
\
- .Case(STR, ABI_VALUE)
+#define X86_FEATURE_COMPAT(ENUM, STR, PRIORITY, ABI_VALUE) .Case(STR,
ABI_VALUE)
#include "llvm/TargetParser/X86TargetParser.def"
;
assert(Feature / 32 < FeatureMask.size());
@@ -797,7 +799,7 @@ unsigned llvm::X86::getFeaturePriority(ProcessorFeatures
Feat) {
#endif
switch (Feat) {
-#define X86_FEATURE_COMPAT(ENUM, STR, PRIORITY, ABI_VALUE)
\
+#define X86_FEATURE_COMPAT(ENUM, STR, PRIORITY, ABI_VALUE)
\
case X86::FEATURE_##ENUM:
\
return PRIORITY;
#include "llvm/TargetParser/X86TargetParser.def"
``````````
</details>
https://github.com/llvm/llvm-project/pull/168750
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
