krasimir added a comment.
Nice!
================
Comment at: lib/Format/UnwrappedLineParser.cpp:461
+
+size_t UnwrappedLineParser::computePPHash() const {
+ size_t h = 0;
----------------
@djasper: do you aware of some baked-in hash-combine functionality in llvm
which this can use directly? If there is no, I'm happy with this.
================
Comment at: unittests/Format/NamespaceEndCommentsFixerTest.cpp:556
+}
+
TEST_F(NamespaceEndCommentsFixerTest,
----------------
Maybe also add some negative tests?
https://reviews.llvm.org/D35483
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
