https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/168214
callOperatorDecl is already of type FunctionDecl *. Identified with readability-redundant-casting. >From cba011852b79b8a9a9368f214605bc5cdb842752 Mon Sep 17 00:00:00 2001 From: Kazu Hirata <[email protected]> Date: Fri, 14 Nov 2025 23:53:24 -0800 Subject: [PATCH] [Analysis] Remove a redundant cast. callOperatorDecl is already of type FunctionDecl *. Identified with readability-redundant-casting. --- clang/lib/Analysis/BodyFarm.cpp | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/clang/lib/Analysis/BodyFarm.cpp b/clang/lib/Analysis/BodyFarm.cpp index c5f35b35ad357..94ab69acef13e 100644 --- a/clang/lib/Analysis/BodyFarm.cpp +++ b/clang/lib/Analysis/BodyFarm.cpp @@ -293,15 +293,14 @@ static CallExpr *create_call_once_lambda_call(ASTContext &C, ASTMaker M, FunctionDecl *callOperatorDecl = CallbackDecl->getLambdaCallOperator(); assert(callOperatorDecl != nullptr); - DeclRefExpr *callOperatorDeclRef = - DeclRefExpr::Create(/* Ctx =*/ C, - /* QualifierLoc =*/ NestedNameSpecifierLoc(), - /* TemplateKWLoc =*/ SourceLocation(), - const_cast<FunctionDecl *>(callOperatorDecl), - /* RefersToEnclosingVariableOrCapture=*/ false, - /* NameLoc =*/ SourceLocation(), - /* T =*/ callOperatorDecl->getType(), - /* VK =*/ VK_LValue); + DeclRefExpr *callOperatorDeclRef = DeclRefExpr::Create( + /* Ctx =*/C, + /* QualifierLoc =*/NestedNameSpecifierLoc(), + /* TemplateKWLoc =*/SourceLocation(), callOperatorDecl, + /* RefersToEnclosingVariableOrCapture=*/false, + /* NameLoc =*/SourceLocation(), + /* T =*/callOperatorDecl->getType(), + /* VK =*/VK_LValue); return CXXOperatorCallExpr::Create( /*AstContext=*/C, OO_Call, callOperatorDeclRef, _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
