github-actions[bot] wrote:
<!--LLVM CODE LINT COMMENT: clang-tidy-->
:warning: C/C++ code linter clang-tidy found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
```bash
git diff -U0 origin/main...HEAD --
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.h
clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp |
python3 clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py \
-path build -p1 -quiet
```
</details>
<details>
<summary>
View the output from clang-tidy here.
</summary>
```
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp:135:3: warning:
do not use 'else' after 'return' [llvm-else-after-return]
135 | else if (const auto *MemberLHS =
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
136 | dyn_cast<MemberExpr>(BinOp->getLHS()->IgnoreImpCasts()))
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
137 | return MemberLHS;
| ~~~~~~~~~~~~~~~~
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp:181:5: warning:
return statement within a void function should not have a specified return
value [readability-avoid-return-with-void-value]
181 | return static_cast<void>(DiagEmitter());
| ^~~~~~
| {
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp:186:5: warning:
return statement within a void function should not have a specified return
value [readability-avoid-return-with-void-value]
186 | return static_cast<void>(DiagEmitter());
| ^~~~~~
| {
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp:191:5: warning:
return statement within a void function should not have a specified return
value [readability-avoid-return-with-void-value]
191 | return static_cast<void>(IgnoreMacros || DiagEmitter());
| ^~~~~~
| {
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp:195:5: warning:
return statement within a void function should not have a specified return
value [readability-avoid-return-with-void-value]
195 | return static_cast<void>(IgnoreMacros || DiagEmitter());
| ^~~~~~
| {
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp:199:5: warning:
return statement within a void function should not have a specified return
value [readability-avoid-return-with-void-value]
199 | return static_cast<void>(IgnoreMacros || DiagEmitter());
| ^~~~~~
| {
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp:205:5: warning:
return statement within a void function should not have a specified return
value [readability-avoid-return-with-void-value]
205 | return static_cast<void>(DiagEmitter());
| ^~~~~~
| {
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp:211:7: warning:
return statement within a void function should not have a specified return
value [readability-avoid-return-with-void-value]
211 | return static_cast<void>(DiagEmitter());
| ^~~~~~
| {
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp:214:7: warning:
return statement within a void function should not have a specified return
value [readability-avoid-return-with-void-value]
214 | return static_cast<void>(IgnoreMacros || DiagEmitter());
| ^~~~~~
| {
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp:218:7: warning:
return statement within a void function should not have a specified return
value [readability-avoid-return-with-void-value]
218 | return static_cast<void>(IgnoreMacros || DiagEmitter());
| ^~~~~~
| {
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp:223:37:
warning: invalid case style for parameter 'ch' [readability-identifier-naming]
223 | [](unsigned char ch) { return std::isspace(ch); });
| ^~ ~~
| Ch Ch
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp:250:7: warning:
isa_and_nonnull<> is preferred over an explicit test for null followed by
calling isa<> [llvm-prefer-isa-or-dyn-cast-in-conditionals]
250 | if (SurroundedExpr && isa<ParenExpr>(SurroundedExpr))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| isa_and_nonnull<ParenExpr>(SurroundedExpr)
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp:261:7: warning:
return statement within a void function should not have a specified return
value [readability-avoid-return-with-void-value]
261 | return static_cast<void>(IgnoreMacros || DiagEmitter());
| ^~~~~~
| {
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp:289:15:
warning: invalid case style for variable 'binOpRoot'
[readability-identifier-naming]
289 | const auto *binOpRoot =
Result.Nodes.getNodeAs<BinaryOperator>("binOpRoot");
| ^~~~~~~~~
| BinOpRoot
290 | const SourceManager &SM = *Result.SourceManager;
291 | ASTContext &Ctx = *Result.Context;
292 | std::optional<bool> RootAssignsToBoolean = std::nullopt;
293 | visitBinaryTreesNode(binOpRoot, nullptr, SM, Ctx,
RootAssignsToBoolean);
| ~~~~~~~~~
| BinOpRoot
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.h:25:8: warning:
function 'clang::tidy::misc::BoolBitwiseOperationCheck::storeOptions' has a
definition with different parameter names
[readability-inconsistent-declaration-parameter-name]
25 | void storeOptions(ClangTidyOptions::OptionMap &Options) override;
| ^
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp:148:33: note:
the definition seen here
148 | void BoolBitwiseOperationCheck::storeOptions(
| ^
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.h:25:8: note:
differing parameters are named here: ('Options'), in definition: ('Opts')
25 | void storeOptions(ClangTidyOptions::OptionMap &Options) override;
| ^ ~~~~~~~
| Opts
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.h:43:50: warning:
invalid case style for parameter 'rootAssignsToBoolean'
[readability-identifier-naming]
43 | std::optional<bool> &rootAssignsToBoolean);
| ^~~~~~~~~~~~~~~~~~~~
| RootAssignsToBoolean
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.h:45:1: warning:
redundant access specifier has the same accessibility as the previous access
specifier [readability-redundant-access-specifiers]
45 | private:
| ^~~~~~~~
clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.h:35:1: note:
previously declared here
35 | private:
| ^
```
</details>
https://github.com/llvm/llvm-project/pull/167552
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
