================
@@ -2579,6 +2591,39 @@ def CIR_FuncOp : CIR_Op<"func", [
   }];
 }
 
+//===----------------------------------------------------------------------===//
+// LLVMIntrinsicCallOp
+//===----------------------------------------------------------------------===//
+
+def CIR_LLVMIntrinsicCallOp : CIR_Op<"llvm.intrinsic"> {
----------------
andykaylor wrote:

```suggestion
def CIR_LLVMIntrinsicCallOp : CIR_Op<"call_llvm_intrinsic"> {
```
The name used in the incubator is quite confusing. Generally, in MLIR 
operations, I expect `<dialect>.<op>` to represent a dialect qualified 
operation, so something like `cir.llvm.intrinsic` doesn't parse right in my 
mind since `cir` and `llvm` both look like dialect qualifiers.

https://github.com/llvm/llvm-project/pull/167401
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to