nightlark wrote:

@henryiii @DeinAlptraum @Endilll @LecrisUT - I made some changes to address the 
remaining feedback; per Henry's suggestion, the backend has been switched over 
to hatchling, which is much faster at building wheels.

I tested pip installing and building wheels under various scenarios to check 
that versions get picked up as expected, and things work as they did before 
with three improvements for the extremely narrow use case of perhaps an LLVM 
developer working specifically on testing these corner cases:
* Installing from the .tar.gz archive GitHub creates for a release gives the 
correct version number: `pip install 
https://github.com/nightlark/llvm-project/archive/refs/tags/llvmorg-20.6.5.tar.gz#subdirectory=clang/bindings/python`
* Installing from the git url works now and picks up the correct version number 
based on if git reference has a tag pointing right at it or not: `pip install 
git+https://github.com/nightlark/llvm-project@add-python-packaging#subdirectory=clang/bindings/python`
* Installing from the source archive for a branch works, but gives a dev 
version: `pip install 
https://github.com/nightlark/llvm-project/archive/refs/heads/add-python-packaging.zip#subdirectory=clang/bindings/python`

As I seem to recall, the main concern @Endill mentioned as the current blocker 
is potential bugs that would be hard to fix due to backwards compatibility 
concerns, so if any reviewers have concrete examples of things that could cause 
those sorts of issues maybe we can get this actually moving forward?

https://github.com/llvm/llvm-project/pull/125806
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to