[PATCH] D34949: [refactor][rename] Use a single base class for class that finds a declaration at location and for class that searches for all occurrences of a specific declaration

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added a comment.

LGTM.



================
Comment at: include/clang/Tooling/Refactoring/RecursiveSymbolVisitor.h:33
+    : public RecursiveASTVisitor<RecursiveSymbolVisitor<T>> {
+  using BaseType = RecursiveASTVisitor<RecursiveSymbolVisitor<T>>;
+  const SourceManager &SM;
----------------
nit: I'd add a `private` specifier for these private members, and put it after 
the `public` section.


Repository:
  rL LLVM

https://reviews.llvm.org/D34949



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits