OCHyams wrote: > I'd be fine with landing this without the endian-ness issue resolved. Perhaps > you could add a note about in the commit message, and add TODOs about > potentially emitting the `DW_AT_data_bit_offset` attribute for big-endian > targets at the two points that the `DW_AT_bit_size` attribute is emitted?
* I've removed the `DwarfCompileUnit` call site as that was only used by types referenced DIExpressions by DW_OP_LLVM_convert (not coming from DIBasicTypes). * Added a TODO to the `DwarfUnit` mentioning the _data_bit_offset * Changed the commit message (PR description). How does this look? What would you like me to put as your name/email for co-authorship? (this was based on your patch and now looks more or less exactly like it!) https://github.com/llvm/llvm-project/pull/164372 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
