carlosgalvezp wrote:

Worth keeping in mind that the rule implements the [C++ Core 
Guidelines](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es31-dont-use-macros-for-constants-or-functions),
 which have a pretty wide ban on macros in general:

> Enforcement Scream when you see a macro that isn’t just used for source 
> control (e.g., #ifdef)

So depending on the interpretation `source control` one may consider the 
warning correct. 

It's possible to whitelist macros via the `AllowedRegexp` option, hopefully 
there's not many?

I do agree clang-tidy should not suggest replacing with a constexpr function in 
this case. 

https://github.com/llvm/llvm-project/pull/164806
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to