DavidSpickett wrote: Perhaps it's not very clear from the docs but option 2 does not require commit access: ``` Two PRs with a dependency note
Create PR_1 for feature_1 and PR_2 for feature_2. In PR_2, include a note in the PR summary indicating that it depends on PR_1 (e.g., “Depends on #PR_1”). To make review easier, make it clear which commits are part of the base PR and which are new, e.g. “The first N commits are from the base PR”. This helps reviewers focus only on the incremental changes. ``` Essentially you have branch 1 with commit A, branch 2 with commits A and B, branch 3 with commits A B and C. On each PR you make, add a comment noting what it depends on. > So, would it be convenient for you if I attach this pitch to this PR? This may be directed to other reviewers, but regardless, putting the pitch in this PR was my intent when I said that. That is, the utility of adding this to clang-tidy and the benefits you think it will bring. In the others, you will justify choices related to the focus of that PR, meaning that here you can assume the underlying changes already exist. https://github.com/llvm/llvm-project/pull/164412 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
