vitalybuka wrote: > So we can bundle those changes them together.
@jyknight our internal ignore lists are mess because of ./ issues. So https://github.com/llvm/llvm-project/pull/162437 fixes this. But to avoid breaking existing users I guard it in v3. It would be nice if we do https://github.com/llvm/llvm-project/pull/162511 and we can move to v3 without breaking existing users (almost, some non-practical cornercases still possible).. But with current state of Windows, and any proposed solution , it's trickier, we need Glob aware "remove_leading_dotslash". Note: with "no.3", if we force / on Windows, we still need own version, but it will be simpler if \ is not part of the path. Same with canonization of patters on load also can have simple version of remove_leading_dotslash, but we will have some complexity in canonization itself. # So my preference is till "no.3", forcing /, as it will be nicer and simpler code. if others strongly against "no.3", I'd prefer canonization of pattern on load. It will make glob matching and #162511 simpler, and will keep "slash-agnostic" specifics very localized. Either are feasible, but we already hit a few bugs during review, and may introduce other going with complicated solutions. https://github.com/llvm/llvm-project/pull/149886 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
