github-actions[bot] wrote:

<!--LLVM CODE LINT COMMENT: clang-tidy-->


:warning: C/C++ code linter clang-tidy found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

```bash

git diff -U0 origin/main...HEAD -- 
clang-tools-extra/clang-tidy/llvm/UseNewMLIROpBuilderCheck.cpp |
python3 clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py \
  -path build -p1 -quiet
```

</details>

<details>
<summary>
View the output from clang-tidy here.
</summary>

```
clang-tools-extra/clang-tidy/llvm/UseNewMLIROpBuilderCheck.cpp:91:16: warning: 
invalid case style for variable 'hasArgs' [readability-identifier-naming]
   91 |     const bool hasArgs = Arg->getKind() != clang::tok::r_paren;
      |                ^~~~~~~
      |                HasArgs
clang-tools-extra/clang-tidy/llvm/UseNewMLIROpBuilderCheck.cpp:127:41: warning: 
invalid case style for variable 'base' [readability-identifier-naming]
  127 |   ast_matchers::internal::Matcher<Stmt> base = cxxMemberCallExpr(
      |                                         ^~~~
      |                                         Base
  128 |       on(expr(anyOf(hasType(BuilderType), 
hasType(pointsTo(BuilderType))))
  129 |              .bind("builder")),
  130 |       callee(expr().bind("call")),
  131 |       callee(cxxMethodDecl(hasTemplateArgument(0, templateArgument()))),
  132 |       callee(cxxMethodDecl(hasName("create"))));
  133 |   return applyFirst(
  134 |       //  Attempt rewrite given an lvalue builder, else just warn.
  135 |       {makeRule(cxxMemberCallExpr(unless(on(cxxTemporaryObjectExpr())), 
base),
      |                                                                         
~~~~
      |                                                                         
Base
  136 |                 rewrite(node("call"), node("builder")), message),
  137 |        makeRule(base, noopEdit(node("call")), message)});
      |                 ~~~~
      |                 Base
```

</details>


https://github.com/llvm/llvm-project/pull/159423
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to