Karthikdhondi wrote: > While GCC has -finline-functions-called-once, we don't blindly copy every > option it supports. Please provide clear, technical justification. The > description looks AI-generated, making it difficult to assess its value. > > > Thanks! I’ve split the change as suggested. > > I don't think you split the LLVM and Clang side changes.
Apologies for not conveying better. We are working on a large application code base that was earlier compiled with GNU toolchain. Compiler option "-fno-inline-functions-called-once" was used. Now considering the benefits of LLVM toolchain, they want to have similar option with LLVM. Using __attribute__((no-inline)), requires making changes to application which is not a feasible option. So, I have enabled the pass in LLVM it worked fine, and thought to create a PR for the same. So that, it might be helpful for others too. By splitting the changes means, Do I need to create two different PRs for LLVM and Clang side changes? https://github.com/llvm/llvm-project/pull/160343 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
