https://github.com/localspook updated https://github.com/llvm/llvm-project/pull/161064
>From 1a0c393d76580488c8a768cfea21214d6c37692a Mon Sep 17 00:00:00 2001 From: Victor Chernyakin <[email protected]> Date: Sun, 28 Sep 2025 01:51:18 -0700 Subject: [PATCH 1/2] [clang-tidy] Fix typoed option name in `bugprone-signed-char-misuse` --- .../clang-tidy/bugprone/SignedCharMisuseCheck.cpp | 6 +++--- .../clang-tidy/bugprone/SignedCharMisuseCheck.h | 2 +- clang-tools-extra/docs/ReleaseNotes.rst | 7 +++++-- .../docs/clang-tidy/checks/bugprone/signed-char-misuse.rst | 2 +- .../checkers/bugprone/signed-char-misuse-with-option.cpp | 2 +- 5 files changed, 11 insertions(+), 8 deletions(-) diff --git a/clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp index 1041355a0caad..742d85bb7bab9 100644 --- a/clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp +++ b/clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp @@ -21,12 +21,12 @@ static constexpr int UnsignedASCIIUpperBound = 127; SignedCharMisuseCheck::SignedCharMisuseCheck(StringRef Name, ClangTidyContext *Context) : ClangTidyCheck(Name, Context), - CharTypdefsToIgnoreList(Options.get("CharTypdefsToIgnore", "")), + CharTypedefsToIgnoreList(Options.get("CharTypedefsToIgnore", "")), DiagnoseSignedUnsignedCharComparisons( Options.get("DiagnoseSignedUnsignedCharComparisons", true)) {} void SignedCharMisuseCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) { - Options.store(Opts, "CharTypdefsToIgnore", CharTypdefsToIgnoreList); + Options.store(Opts, "CharTypedefsToIgnore", CharTypedefsToIgnoreList); Options.store(Opts, "DiagnoseSignedUnsignedCharComparisons", DiagnoseSignedUnsignedCharComparisons); } @@ -39,7 +39,7 @@ BindableMatcher<clang::Stmt> SignedCharMisuseCheck::charCastExpression( // (e.g. typedef char sal_Int8). In this case, we don't need to // worry about the misinterpretation of char values. const auto IntTypedef = qualType(hasDeclaration(typedefDecl( - hasAnyName(utils::options::parseStringList(CharTypdefsToIgnoreList))))); + hasAnyName(utils::options::parseStringList(CharTypedefsToIgnoreList))))); auto CharTypeExpr = expr(); if (IsSigned) { diff --git a/clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.h b/clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.h index c735ac634c801..515b85891269c 100644 --- a/clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.h +++ b/clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.h @@ -35,7 +35,7 @@ class SignedCharMisuseCheck : public ClangTidyCheck { const ast_matchers::internal::Matcher<clang::QualType> &IntegerType, const std::string &CastBindName) const; - const StringRef CharTypdefsToIgnoreList; + const StringRef CharTypedefsToIgnoreList; const bool DiagnoseSignedUnsignedCharComparisons; }; diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst index 7cdff86beeec6..29d8bcdd4e68f 100644 --- a/clang-tools-extra/docs/ReleaseNotes.rst +++ b/clang-tools-extra/docs/ReleaseNotes.rst @@ -58,8 +58,11 @@ Potentially Breaking Changes :doc:`bugprone-easily-swappable-parameters <clang-tidy/checks/bugprone/easily-swappable-parameters>` from ``NamePrefixSuffixSilenceDissimilarityTreshold`` to - ``NamePrefixSuffixSilenceDissimilarityThreshold``, - correcting a spelling mistake. + ``NamePrefixSuffixSilenceDissimilarityThreshold`` and of check + :doc:`bugprone-signed-char-misuse + <clang-tidy/checks/bugprone/signed-char-misuse>` from + ``CharTypdefsToIgnore`` to ``CharTypedefsToIgnore``, + correcting spelling mistakes. Improvements to clangd ---------------------- diff --git a/clang-tools-extra/docs/clang-tidy/checks/bugprone/signed-char-misuse.rst b/clang-tools-extra/docs/clang-tidy/checks/bugprone/signed-char-misuse.rst index 4edbad5eac81b..3e06e11dffcc7 100644 --- a/clang-tools-extra/docs/clang-tidy/checks/bugprone/signed-char-misuse.rst +++ b/clang-tools-extra/docs/clang-tidy/checks/bugprone/signed-char-misuse.rst @@ -107,7 +107,7 @@ so both arguments will have the same type. Options ------- -.. option:: CharTypdefsToIgnore +.. option:: CharTypedefsToIgnore A semicolon-separated list of typedef names. In this list, we can list typedefs for ``char`` or ``signed char``, which will be ignored by the diff --git a/clang-tools-extra/test/clang-tidy/checkers/bugprone/signed-char-misuse-with-option.cpp b/clang-tools-extra/test/clang-tidy/checkers/bugprone/signed-char-misuse-with-option.cpp index 9f9d61a56f6c3..c11be9414ac70 100644 --- a/clang-tools-extra/test/clang-tidy/checkers/bugprone/signed-char-misuse-with-option.cpp +++ b/clang-tools-extra/test/clang-tidy/checkers/bugprone/signed-char-misuse-with-option.cpp @@ -1,6 +1,6 @@ // RUN: %check_clang_tidy %s bugprone-signed-char-misuse %t \ // RUN: -config='{CheckOptions: \ -// RUN: {bugprone-signed-char-misuse.CharTypdefsToIgnore: "sal_Int8;int8_t"}}' \ +// RUN: {bugprone-signed-char-misuse.CharTypedefsToIgnore: "sal_Int8;int8_t"}}' \ // RUN: -- /////////////////////////////////////////////////////////////////// >From 9e06e5edd6d158dfd0a470b8ed0ed4601f20c3e4 Mon Sep 17 00:00:00 2001 From: Victor Chernyakin <[email protected]> Date: Sun, 28 Sep 2025 17:57:51 -0700 Subject: [PATCH 2/2] Adjust release notes --- clang-tools-extra/docs/ReleaseNotes.rst | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst index 29d8bcdd4e68f..f17db4acc08ad 100644 --- a/clang-tools-extra/docs/ReleaseNotes.rst +++ b/clang-tools-extra/docs/ReleaseNotes.rst @@ -54,15 +54,17 @@ Potentially Breaking Changes :program:`clang-tidy-20`. Users should use the check-specific options of the same name instead. -- Renamed :program:`clang-tidy`'s option name of check - :doc:`bugprone-easily-swappable-parameters - <clang-tidy/checks/bugprone/easily-swappable-parameters>` from - ``NamePrefixSuffixSilenceDissimilarityTreshold`` to - ``NamePrefixSuffixSilenceDissimilarityThreshold`` and of check - :doc:`bugprone-signed-char-misuse - <clang-tidy/checks/bugprone/signed-char-misuse>` from - ``CharTypdefsToIgnore`` to ``CharTypedefsToIgnore``, - correcting spelling mistakes. +- Renamed a few :program:`clang-tidy` check options, as they + were misspelled: + + - `NamePrefixSuffixSilenceDissimilarityTreshold` → + `NamePrefixSuffixSilenceDissimilarityThreshold` in + :doc:`bugprone-easily-swappable-parameters + <clang-tidy/checks/bugprone/easily-swappable-parameters>` + + - `CharTypdefsToIgnore` → `CharTypedefsToIgnore` in + :doc:`bugprone-signed-char-misuse + <clang-tidy/checks/bugprone/signed-char-misuse>` Improvements to clangd ---------------------- _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
