================
@@ -856,19 +856,19 @@ class ParsedAttributesView {
     friend class ParsedAttributesView;
   };
 
-  void addAll(iterator B, iterator E) {
+  void prependAll(iterator B, iterator E) {
----------------
compnerd wrote:

Does it make sense to consider the C++ STL behaviours? The `All` suffix would 
generally not be something that the C++ STL would ever use as you are giving an 
iterator range, so you know that it is everything in that range. That is, 
`prepend(attributes.begin(), attributes.end())` which is often spelt `insert(0, 
attributes.begin(), attributes.end())`

https://github.com/llvm/llvm-project/pull/162714
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to