zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.

I don't have any comments, this seems fine to me.  Long term I think the best 
solution is to get rid of these global specializations entirely, and instead 
provide adapters called `flow` and `block`, and instead of just saying 
`IO.mapOptional("Foo", Sequence);` and having it be picked up by a 
specialization, you would say `IO.mapOptional("Foo", flow(Sequence));`


Repository:
  rL LLVM

https://reviews.llvm.org/D34907



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D34907: f... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D349... Zachary Turner via Phabricator via cfe-commits
    • [PATCH] D349... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D349... Richard Smith - zygoloid via Phabricator via cfe-commits

Reply via email to