SergejSalnikov wrote: > it's probably not practical to test all the modified code paths - any > thoughts on what the right testing tradeoff is here? That various codepaths > /inside/ getRefinedSpellingLoc are tested, from perhaps a variety of call > sites/ways that manifests in the resulting IR metadata without being > exhaustive, seems OK to me? (so perhaps in the test case at least an > instruction location and a type location could be tested?)
I've added asserts in the places where we already expect the file location. This is an optimization to avoid expansion for the same location 3 or more times. We usually perform 3 operations back to back: `getFileID`, `getFileName`, `getLineNumber`. https://github.com/llvm/llvm-project/pull/163190 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
