bader wrote:

> I don't have more changes in this PR. The sycl toolchain can be invoked via 
> CL compatibility mode in driver, so I enable this option in CL compatibility 
> mode.

If I get it right, `--[no-]offloadlib` option can be used in SYCL even w/o this 
patch, so the title is misleading. The change has no functional changes for 
SYCL. Please, remove SYCL and add tags to the PR title. E.g. `[Clang][Driver] 
Enable offloadlib option for clang-cl`.

> --[no-]offloadlib option is used by rocm and cuda toolchain to enable/disable 
> device libraries in linking phase for device code. It makes sense to re-use 
> this option in sycl for similar purpose and since clang driver support sycl 
> in CL compatibility mode as well, we also need to enable this option in CL 
> compatibility mode.

Please, capitalize SYCL in the description: sycl -> SYCL.


https://github.com/llvm/llvm-project/pull/162980
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to