https://github.com/NagyDonat approved this pull request.

LGTM, seems to be a nice simplification.

Note that `skipinitialspace` is not completely identical to the `.strip()` call 
because it only strips the whitespace _before_ the actual value, while 
`.strip()` would also strip whitespace after the value (and before the next 
value). If this script needs to handle input like `foo , bar , baz , spam` 
(with spaces before the delimiter `,`), then you should keep the original code. 
(However, I presume that your usecase is handling input like `foo, bar, baz, 
spam`.)

https://github.com/llvm/llvm-project/pull/161665
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to