sharadhr wrote:

@YexuanXiao fair point. 

1. Perhaps. I am more in favour of aliasing `--sysroot` as `/winsysroot` for 
`clang-cl` rather than fundamentally changing the delivery, layout, or 
otherwise significantly modifying the Windows SDK/MSVC libraries and headers. 
There are more accessible, less invasive, and less pervasive workarounds. 

2. Even if the script can be maintained, it means supporting not one but _two_ 
setups. We can't just _drop_ existing clang-cl behaviour—many users are 
directly on Windows with an MSVC-provided toolchain (that is, using the 
official installer and not tools like xwin). 

I feel this is a solution looking for a problem. The MSVC SDK has a different 
layout; LLVM and Clang was built explicitly to handle it, and `clang-cl` 
handles it correctly under a cross-compile scenario with `/winsysroot` (or 
`/winsdkdir` and `/vctoolsdir`) and a properly-setup sysroot; that is all 
that's needed. 

I want to remind us of what [`clang-cl` is meant 
for](https://clang.llvm.org/docs/UsersManual.html#clang-cl):

> clang-cl is an alternative command-line interface to Clang, designed for 
> compatibility with the Visual C++ compiler, cl.exe. 

https://github.com/llvm/llvm-project/pull/96417
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to