majnemer added a comment.

In https://reviews.llvm.org/D34714#793205, @rnk wrote:

> Did you locally add a test case for the dllimport member function pointer 
> template argument?


Arg, yes. Forgot to add the file...



================
Comment at: lib/Sema/SemaTemplate.cpp:5704
+  else
+    NPV = isNullPointerValueTemplateArgument(S, Param, ParamType, ResultArg);
+
----------------
rnk wrote:
> Think we should pass in Entity as an optional parameter to 
> isNullPointerValueTemplateArgument to share the logic?
Seems reasonable, I'll give that a go.


https://reviews.llvm.org/D34714



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to