jhuber6 wrote:

> Thanks, that's definitely a significant step closer. I've given this a more 
> detailed review. Unfortunately, writing builtins with custom type-checking 
> can be a little tricky because of the range of languages we support in Clang. 
> It mostly just involves making calls that you're supposed to be making anyway 
> and checking for dependent types, but it's something every builtin needs to 
> be doing.

Thanks, hopefully this is closer to what you had in mind now. It's definitely a 
lot of work to do all this type checking manually but I have a much better idea 
of what the edge cases we check for are. Appreciate the thorough reviews.

https://github.com/llvm/llvm-project/pull/160185
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to