================ @@ -294,6 +294,11 @@ std::string complexRangeKindToStr(LangOptions::ComplexRangeKind Range); // Render a frontend option corresponding to ComplexRangeKind. std::string renderComplexRangeOption(LangOptions::ComplexRangeKind Range); +// Set the complex range and output a warning as needed. +void setComplexRange(const Driver &D, StringRef &LastOpt, ---------------- tarunprabhu wrote:
If I understand this correctly, we could replace the call to `setComplexRange` with two assignments and the conditional emission of a diagnostic. I agree that this would be somewhat repetitive code, although I think it would be a bit more clear. Since neither approach is clearly better (or worse) than the other, it's ok to just move theparameters to the last position of the argument list. https://github.com/llvm/llvm-project/pull/159689 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
