llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) <details> <summary>Changes</summary> That patch tried to ensure a TypeSourceInfo for a destructor name. However, we don't actually have one during error recovery, so we should bail in that case. No release note, since it's a regression and a backport could improve the stability of clangd. Fixes https://github.com/llvm/llvm-project/issues/159630 --- Full diff: https://github.com/llvm/llvm-project/pull/159976.diff 2 Files Affected: - (modified) clang/lib/Sema/SemaExprCXX.cpp (+2) - (modified) clang/test/SemaTemplate/destructor-template.cpp (+15) ``````````diff diff --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp index 5a9279d928465..0c04d01e77024 100644 --- a/clang/lib/Sema/SemaExprCXX.cpp +++ b/clang/lib/Sema/SemaExprCXX.cpp @@ -354,6 +354,8 @@ ParsedType Sema::getDestructorName(const IdentifierInfo &II, CheckTypenameType(ElaboratedTypeKeyword::None, SourceLocation(), SS.getWithLocInContext(Context), II, NameLoc, &TSI, /*DeducedTSTContext=*/true); + if (T.isNull()) + return ParsedType(); return CreateParsedType(T, TSI); } diff --git a/clang/test/SemaTemplate/destructor-template.cpp b/clang/test/SemaTemplate/destructor-template.cpp index 7a3398308bbee..734269e854e5d 100644 --- a/clang/test/SemaTemplate/destructor-template.cpp +++ b/clang/test/SemaTemplate/destructor-template.cpp @@ -104,3 +104,18 @@ struct T : S { ~T() = default; }; } // namespace PR38671 + +namespace GH159630 { + +struct X { + template<typename T> + struct typo { // expected-note {{'typo' declared here}} + ~typo(); + }; +}; + +template<typename T> +X::typo<T>::typ0::~typ0() {} // expected-error {{no member named 'typ0'}} \ + // expected-error {{no type named 'typ0'}} + +} `````````` </details> https://github.com/llvm/llvm-project/pull/159976 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
