mstorsjo wrote: This had me a bit surprised, because I build the latest libunwind nightly, with the latest clang, and haven't run into this.
But the reason for that, is that mingw has got `EXCEPTION_DISPOSITION` defined as `int`, see https://github.com/mingw-w64/mingw-w64/blob/v13.0.0/mingw-w64-headers/crt/excpt.h#L19-L26 - while MSVC headers have it as an actual enum. So this issue is observable only if building in MSVC mode. IIRC there are a few other issues if building libunwind in MSVC mode as well (and libunwind isn't really very useful for much in a MSVC mode environment anyway - but if you have a specific use case for it there I'm interested in hearing!). Anyway, the change itself looks fine to me (although we perhaps should use `static_cast<>()` instead). https://github.com/llvm/llvm-project/pull/159293 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
