================
@@ -52,6 +54,23 @@ LLVM_ABI llvm::Error wrapHIPBinary(llvm::Module &M,
llvm::ArrayRef<char> Images,
EntryArrayTy EntryArray,
llvm::StringRef Suffix = "",
bool EmitSurfacesAndTextures = true);
+
+struct SYCLWrappingOptions {
----------------
bader wrote:
Based on the members description this structure holds options for the runtime
compiler (aka JIT compiler). I think it's better to reflect in the structure
name.
```suggestion
struct SYCLJITOptions {
```
Or maybe even just "JITOptions". These are specific to the device code format
rather than a programming model. If we use some intermediate representation
(e.g. SPIR-V), which just be compiled to the executable format, these options
are useful to configure the runtime compilation step.
@sarnex, does OpenMP offload to SPIR-V compiler allows setting JIT compiler
options? If so, I think this structure should have a neutral name like
"JITOptions" and re-used by different offloading modes.
https://github.com/llvm/llvm-project/pull/147508
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
