https://github.com/NagyDonat commented:
I'm very happy to see that you are implementing these enhancements; they were also on my long-term todo list but I didn't know when would I have time for implementing them. Unfortunately it seems that your commit duplicates several hundred lines of code, instead of reusing the existing code (with suitable generalizations and tweaks): | Old code | Duplicated in | Line count | | --- | --- | --- | | StateUpdateReporter | StateIndexUpdateReporter | ~45 | https://github.com/llvm/llvm-project/pull/159357 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
