Author: Martin Storsjö Date: 2025-09-17T20:46:44+03:00 New Revision: 6db244a58626e885ba010b3d6813191485e18e90
URL: https://github.com/llvm/llvm-project/commit/6db244a58626e885ba010b3d6813191485e18e90 DIFF: https://github.com/llvm/llvm-project/commit/6db244a58626e885ba010b3d6813191485e18e90.diff LOG: Add parentheses to clarify operator ordering in asserts. NFC. (#159333) This avoids the following kind of warning with GCC: ../tools/llvm-lipo/llvm-lipo.cpp: In function ‘void printInfo(llvm::LLVMContext&, llvm::ArrayRef<llvm::object::OwningBinary<llvm::object::Binary> >)’: ../tools/llvm-lipo/llvm-lipo.cpp:464:34: warning: suggest parentheses around ‘& ’ within ‘||’ [-Wparentheses] 464 | Binary->isArchive() && "expected MachO binary"); | ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ Added: Modified: clang/lib/CodeGen/CGHLSLRuntime.cpp llvm/tools/llvm-lipo/llvm-lipo.cpp Removed: ################################################################################ diff --git a/clang/lib/CodeGen/CGHLSLRuntime.cpp b/clang/lib/CodeGen/CGHLSLRuntime.cpp index 49bc408a1b305..cf018c8c7de2a 100644 --- a/clang/lib/CodeGen/CGHLSLRuntime.cpp +++ b/clang/lib/CodeGen/CGHLSLRuntime.cpp @@ -922,9 +922,9 @@ void CGHLSLRuntime::emitInitListOpaqueValues(CodeGenFunction &CGF, std::optional<LValue> CGHLSLRuntime::emitResourceArraySubscriptExpr( const ArraySubscriptExpr *ArraySubsExpr, CodeGenFunction &CGF) { - assert(ArraySubsExpr->getType()->isHLSLResourceRecord() || - ArraySubsExpr->getType()->isHLSLResourceRecordArray() && - "expected resource array subscript expression"); + assert((ArraySubsExpr->getType()->isHLSLResourceRecord() || + ArraySubsExpr->getType()->isHLSLResourceRecordArray()) && + "expected resource array subscript expression"); // Let clang codegen handle local resource array subscripts, // or when the subscript references on opaque expression (as part of diff --git a/llvm/tools/llvm-lipo/llvm-lipo.cpp b/llvm/tools/llvm-lipo/llvm-lipo.cpp index d4b1f8f3dd7d4..3e1d4165e8ed7 100644 --- a/llvm/tools/llvm-lipo/llvm-lipo.cpp +++ b/llvm/tools/llvm-lipo/llvm-lipo.cpp @@ -460,8 +460,8 @@ printInfo(LLVMContext &LLVMCtx, ArrayRef<OwningBinary<Binary>> InputBinaries) { for (auto &IB : InputBinaries) { const Binary *Binary = IB.getBinary(); if (!Binary->isMachOUniversalBinary()) { - assert(Binary->isMachO() || - Binary->isArchive() && "expected MachO binary"); + assert((Binary->isMachO() || Binary->isArchive()) && + "expected MachO binary"); outs() << "Non-fat file: " << Binary->getFileName() << " is architecture: "; printBinaryArchs(LLVMCtx, Binary, outs()); _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
