=?utf-8?q?Félix-Antoine?= Constantin
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/[email protected]>


================
@@ -88,12 +90,22 @@ class FindEnumMember : public TypeVisitor<FindEnumMember, 
bool> {
 
 InvalidEnumDefaultInitializationCheck::InvalidEnumDefaultInitializationCheck(
     StringRef Name, ClangTidyContext *Context)
-    : ClangTidyCheck(Name, Context) {}
+    : ClangTidyCheck(Name, Context),
+      IgnoredEnums(utils::options::parseStringList(
+          Options.get("IgnoredEnums", "::std::errc"))) {}
----------------
vbvictor wrote:

Seems strange that we check enums from `std` in the first place. I think this 
check needs `unless(isExpansionInSystemHeader())` to ingore enums that we don't 
have control of.
But this could be for another PR. We did similar fixes in the past: 
https://github.com/llvm/llvm-project/pull/135831

https://github.com/llvm/llvm-project/pull/159220
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to