carlosgalvezp wrote: > This could also backfire for users that use "old" c++11. Imagine if the > default standard is increased in `check_clang_tidy.py`, then the people who > develop checks (and write tests) will unintentionally use c++14 as the > default mode. Matchers written with c++14 in mind, may not work in c++11 (I > encountered such behavior while developing checks). So the `clang-tidy` users > with `std=c++11` will see that the check doesn't work.
Yes. I think we should think carefully about what the default standard means and should be, and when it should be bumped. If a check promises to work with "any" C++ standard (as is often the case), then it should in theory test all the standards it promises. Testing only C++11 or later risks the check not working for C++98 and C++03 for example. In other words I think the default standard in `run_clang_tidy.py` should be the oldest version we want to support in testing, and that CI can afford. Hard to know when it should be bumped, but we should have some confidence that the majority of users no longer uses an old standard. https://github.com/llvm/llvm-project/pull/158196 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
