hfinkel added a comment. In general, this patch seems to be missing tests (unless it is actually NFC, or you can't write tests yet, which, in either case, need to be explained).
================ Comment at: lib/Driver/ToolChains/Cuda.cpp:217 + std::vector<std::string> GPUArchNames; + // If this is an OpenMP action we need to extract the device architecture from + // the -march option. ---------------- Do we have a test case for this? ================ Comment at: lib/Driver/ToolChains/Cuda.cpp:435 + + // TODO: get the compute capability from offloading arguments when not + // using the default compute capability of sm_20. ---------------- Why is this a TODO? Is the necessary information not currently available in the offloading arguments, or are we just not grabbing it in this patch? Repository: rL LLVM https://reviews.llvm.org/D29647 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
