Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]>, Burhan =?utf-8?b?U8O2xJ/DvHQ=?= <[email protected]> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/[email protected]>
AmrDeveloper wrote: > > Thanks for removing other files. Can you please check those nits > > For comments related to updating pattern matching, for example, to be > > similar to other tests `%[[NAME: REGEX]]`. If you want to do it, I can > > guide you more; if not, we can delay it later > > Sure. I'd like to try updating the pattern matching now. Your guidance would > be very helpful. I want to learn more! Thank you for updating the nits. So, for updating the pattern matching, we want to make it similar to other tests. 1 - Varables for example `%1`, `%a`, lets capture them and keep `%` outside, for example `[[A:%.*]]` should be converted to `%[[A:.*]]`, and when you use it, it will be `%[[A]]`. 2 - We don't use the prefix # in variable names, for example `// CHECK: %[[#C:]] = cir.const #cir.int<1> : !s32i` Should be converted to, and also when you capture a variable, let's use `:.*` unless you want to capture a specific pattern like a number or alphabet only, the result will be `// CHECK: %[[C:.*]] = cir.const #cir.int<1> : !s32i` And when you check that this variable is used, it will be `%[[C]]`, not `%[[#C]] Let's do it step by step in the current tests, and if you are confused about any pattern, please share it and let's discuss it in the comments. https://github.com/llvm/llvm-project/pull/157333 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
