cyndyishida wrote: > FYI, this change caused some kinda noisy warnings from GCC, and the warnings > don't sound entirely bogus: > > ``` > In file included from > ../../clang/include/clang/Serialization/ASTRecordReader.h:20, > from ../../clang/lib/Serialization/ASTReaderDecl.cpp:55: > ../../clang/include/clang/Serialization/ASTReader.h:246:16: warning: ‘virtual > bool clang::ASTReaderListener::visitInputFile(llvm::StringRef, > llvm::StringRef, bool, bool, bool)’ was hidden [-Woverloaded-virtual=] > 246 | virtual bool visitInputFile(StringRef FilenameAsRequested, > StringRef Filename, > | ^~~~~~~~~~~~~~ > ../../clang/include/clang/Serialization/ASTReader.h:307:8: note: by > ‘virtual bool > clang::ChainedASTReaderListener::visitInputFile(llvm::StringRef, bool, bool, > bool)’ > 307 | bool visitInputFile(StringRef Filename, bool isSystem, > | ^~~~~~~~~~~~~~ > ``` > > What do you think about these warnings, is it something we could avoid by > clarifying the code, to avoid the name collision for virtual and non-virtual > method?
Thanks for reporting! I have a fix proposed in https://github.com/llvm/llvm-project/pull/157501 https://github.com/llvm/llvm-project/pull/132237 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
