mizvekov wrote: > I noticed that some tests are dropped in the PR, esp. eg. in the AST > unittests. Did you check the test coverage if that wouldn't shrink due to > those removals? In the ASTImporter I remember a few years ago we added some > tests to exercise the uncovered ctors and getters or some AST constructs. If > the coverage is as good as before, I'm good with the change. Thank you!
The tests and parts of tests I removed were specifically testing for the removed bit, so I don't think any of this reduces test coverage. https://github.com/llvm/llvm-project/pull/155120 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
