Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land.
LGTM! Small comment in the test can be addressed in commit! ================ Comment at: test/SemaOpenCL/storageclass.cl:52 +kernel void invalidScope() { + if (true) { + local int lInt; // expected-error {{variables in the local address space can only be declared in the outermost scope of a kernel function}} ---------------- I would just move this into `foo` as it tests similar functionality already. https://reviews.llvm.org/D34024 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits