https://github.com/frasercrmck approved this pull request.

LGTM.

My main question is - why not make _all_ definitions weak? The alternative is 
to make them weak as and when we or a downstream needs them, or come up with 
some rationale for which ones are or aren't weak.

https://github.com/llvm/llvm-project/pull/156378
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to