erichkeane wrote: > > CC @nikic could you put this on llvm-compile-time-tracker so we know what > > the overhead of this is if any? > > Not seeing an impact when applying this patch -- but that's probably expected > as the warning is not enabled by default? I'd probably additional changes to > enable it.
It does the analysis all the time, but the situation in which it uses the analysis (if with condition var, also has an else) is reasonably limited. So you'd need a fairly sizable 'else' for the visitor to have to do a bunch of work. I don't anticipate the situation there to be particularly common in our build suite though. That said, this is still going to be a pretty bad perf in cases that DO have that, just not in our test suite. https://github.com/llvm/llvm-project/pull/156436 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
