jj-marr wrote: @SunBlack I'm still in favour of the check but I didn't see myself working on it until C++26 as it won't be usable for many people.
I would prefer Option 2 if I was still working on this. In the example you gave, the initializer list should be in a constexpr std::array to avoid using magic numbers. > Isn't that only relevant if an at() occurs in the method that is to be > adapted? This is a footgun, because I believe `std::span<T, N>` does bounds-checking dependent on `N`. Refactoring `std::array<T, N>` to `std::span<T>` could be unsafe since `N` would be defaulted to a "dynamic extent" and the size is no longer encoded in the type. [Cpp insights](https://cppinsights.io/lnk?code=I2luY2x1ZGUgPGNocm9ubz4KI2luY2x1ZGUgPGNzdGRkZWY+CiNpbmNsdWRlIDxpb3N0cmVhbT4KI2luY2x1ZGUgPHNwYW4+CiNpbmNsdWRlIDxzdGRleGNlcHQ+CiAKaW50IG1haW4oKQp7CiAgICBpbnQgeFtdezEsIDIsIDQsIDUsIDUsIDZ9OwogICAgc3RkOjpzcGFuPGludD4gZGF0YSh4KTsKIAogICAgLy8gU2V0IGVsZW1lbnQgMQogICAgZGF0YS5hdCgxKSA9IDg4OwogCiAgICAvLyBSZWFkIGVsZW1lbnQgMgogICAgc3RkOjpjb3V0IDw8ICJFbGVtZW50IGF0IGluZGV4IDIgaGFzIHZhbHVlICIgPDwgZGF0YS5hdCgyKSA8PCAnXG4nOwogCiAgICBzdGQ6OmNvdXQgPDwgImRhdGEgc2l6ZSA9ICIgPDwgZGF0YS5zaXplKCkgPDwgJ1xuJzsKIAogICAgdHJ5CiAgICB7CiAgICAgICAgLy8gVHJ5IHRvIHNldCBhbiBlbGVtZW50IGF0IHJhbmRvbSBwb3NpdGlvbiA+PSBzaXplKCkKICAgICAgICBhdXRvIG1vb25fcGhhc2UgPSBbXQogICAgICAgIHsKICAgICAgICAgICAgcmV0dXJuIHN0ZDo6Y2hyb25vOjpzeXN0ZW1fY2xvY2s6Om5vdygpLnRpbWVfc2luY2VfZXBvY2goKS5jb3VudCgpICUgODsKICAgICAgICB9OwogICAgICAgIGRhdGEuYXQoZGF0YS5zaXplKCkgKyBtb29uX3BoYXNlKCkpID0gMTM7CiAgICB9CiAgICBjYXRjaChjb25zdCBzdGQ6Om91dF9vZl9yYW5nZSYgZXgpCiAgICB7CiAgICAgICAgc3RkOjpjb3V0IDw8IGV4LndoYXQoKSA8PCAnXG4nOwogICAgfQogCiAgICAvLyBQcmludCBmaW5hbCB2YWx1ZXMKICAgIHN0ZDo6Y291dCA8PCAiZGF0YToiOwogICAgZm9yIChpbnQgZWxlbSA6IGRhdGEpCiAgICAgICAgc3RkOjpjb3V0IDw8ICcgJyA8PCBlbGVtOwogICAgc3RkOjpjb3V0IDw8ICdcbic7Cn0=&insightsOptions=cpp2c&std=cpp2c&rev=1.0) not sure what the full implications of this are. https://github.com/llvm/llvm-project/pull/140001 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
