[clang] [X86] Add -fexperimental-new-constant-interpreter test coverage to the u32/f32 u64/f64 cast constexpr test files (PR #156327)

[Simon Pilgrim via cfe-commits]

https://github.com/RKSimon created 
https://github.com/llvm/llvm-project/pull/156327

Update tests to use builtin_test_helpers.h and the TEST_CONSTEXPR helper macro

Partial fix for #155814

>From 1d0576366143f74479300fec33bb494a695e98c6 Mon Sep 17 00:00:00 2001
From: Simon Pilgrim <llvm-...@redking.me.uk>
Date: Mon, 1 Sep 2025 14:27:21 +0100
Subject: [PATCH] [X86] Add -fexperimental-new-constant-interpreter test
 coverage to the u32/f32 u64/f64 cast constexpr test files

Update tests to use builtin_test_helpers.h and the TEST_CONSTEXPR helper macro

Partial fix for #155814
---
 clang/test/CodeGen/X86/x86-builtins.c | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/clang/test/CodeGen/X86/x86-builtins.c 
b/clang/test/CodeGen/X86/x86-builtins.c
index e503e475db012..37cfe3e242f53 100644
--- a/clang/test/CodeGen/X86/x86-builtins.c
+++ b/clang/test/CodeGen/X86/x86-builtins.c
@@ -1,39 +1,40 @@
 // RUN: %clang_cc1 -x c -ffreestanding %s -triple=x86_64-unknown-unknown 
-emit-llvm -o - -Wall -Werror | FileCheck %s
 // RUN: %clang_cc1 -x c -ffreestanding %s -triple=i386-unknown-unknown 
-emit-llvm -o - -Wall -Werror | FileCheck %s
-// RUN: %clang_cc1 -x c++ -std=c++11 -ffreestanding %s 
-triple=x86_64-unknown-unknown -emit-llvm -o - -Wall -Werror | FileCheck %s
-// RUN: %clang_cc1 -x c++ -std=c++11 -ffreestanding %s 
-triple=i386-unknown-unknown -emit-llvm -o - -Wall -Werror | FileCheck %s
+// RUN: %clang_cc1 -x c++ -ffreestanding %s -triple=x86_64-unknown-unknown 
-emit-llvm -o - -Wall -Werror | FileCheck %s
+// RUN: %clang_cc1 -x c++ -ffreestanding %s -triple=i386-unknown-unknown 
-emit-llvm -o - -Wall -Werror | FileCheck %s
+
+// RUN: %clang_cc1 -x c -ffreestanding %s -triple=x86_64-unknown-unknown 
-emit-llvm -o - -Wall -Werror -fexperimental-new-constant-interpreter | 
FileCheck %s
+// RUN: %clang_cc1 -x c -ffreestanding %s -triple=i386-unknown-unknown 
-emit-llvm -o - -Wall -Werror -fexperimental-new-constant-interpreter | 
FileCheck %s
+// RUN: %clang_cc1 -x c++ -ffreestanding %s -triple=x86_64-unknown-unknown 
-emit-llvm -o - -Wall -Werror -fexperimental-new-constant-interpreter | 
FileCheck %s
+// RUN: %clang_cc1 -x c++ -ffreestanding %s -triple=i386-unknown-unknown 
-emit-llvm -o - -Wall -Werror -fexperimental-new-constant-interpreter | 
FileCheck %s
 
 #include <x86intrin.h>
+#include "builtin_test_helpers.h"
 
 unsigned int test_castf32_u32 (float __A){
   // CHECK-LABEL: test_castf32_u32
   // CHECK: %{{.*}} = load i32, ptr %{{.*}}, align 4
   return _castf32_u32(__A);
 }
+TEST_CONSTEXPR(_castf32_u32(-0.0f) == 0x80000000);
 
 unsigned long long test_castf64_u64 (double __A){
   // CHECK-LABEL: test_castf64_u64
   // CHECK: %{{.*}} = load i64, ptr %{{.*}}, align 8
   return _castf64_u64(__A);
 }
+TEST_CONSTEXPR(_castf64_u64(-0.0) == 0x8000000000000000);
 
 float test_castu32_f32 (unsigned int __A){
   // CHECK-LABEL: test_castu32_f32
   // CHECK: %{{.*}} = load float, ptr %{{.*}}, align 4
   return _castu32_f32(__A);
 }
+TEST_CONSTEXPR(_castu32_f32(0x3F800000) == +1.0f);
 
 double test_castu64_f64 (unsigned long long __A){
   // CHECK-LABEL: test_castu64_f64
   // CHECK: %{{.*}} = load double, ptr %{{.*}}, align 8
   return _castu64_f64(__A);
 }
-
-// Test constexpr handling.
-#if defined(__cplusplus) && (__cplusplus >= 201103L)
-char cast_f32_u32_0[_castf32_u32(-0.0f) == 0x80000000 ? 1 : -1];
-char cast_u32_f32_0[_castu32_f32(0x3F800000) == +1.0f ? 1 : -1];
-
-char castf64_u64_0[_castf64_u64(-0.0) == 0x8000000000000000 ? 1 : -1];
-char castu64_f64_0[_castu64_f64(0xBFF0000000000000ULL) == -1.0 ? 1 : -1];
-#endif
+TEST_CONSTEXPR(_castu64_f64(0xBFF0000000000000ULL) == -1.0);

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits