https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/155548

>From 893813ce1e131f5a2948f0ab9745c87b67baf33e Mon Sep 17 00:00:00 2001
From: Nathan Ridge <zeratul...@hotmail.com>
Date: Wed, 27 Aug 2025 00:28:40 -0400
Subject: [PATCH 1/2] [clang][Sema] Shard out SemaTests into their own binary

---
 clang/unittests/Sema/CMakeLists.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/clang/unittests/Sema/CMakeLists.txt 
b/clang/unittests/Sema/CMakeLists.txt
index acc76c932afeb..51d49006f57ff 100644
--- a/clang/unittests/Sema/CMakeLists.txt
+++ b/clang/unittests/Sema/CMakeLists.txt
@@ -1,4 +1,7 @@
-add_clang_unittest(SemaTests
+# There are only a small number of tests here,
+# allow running them without building all of
+# AllClangUnitTests.
+add_distinct_clang_unittest(SemaTests
   ExternalSemaSourceTest.cpp
   CodeCompleteTest.cpp
   HeuristicResolverTest.cpp

>From 925749fbe33d864082cfcb65dbb6ef9c7953bcb3 Mon Sep 17 00:00:00 2001
From: Reid Kleckner <r...@google.com>
Date: Thu, 28 Aug 2025 09:52:37 -0700
Subject: [PATCH 2/2] Clarify purpose of SemaTests in CMakeLists.txt

---
 clang/unittests/Sema/CMakeLists.txt | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/clang/unittests/Sema/CMakeLists.txt 
b/clang/unittests/Sema/CMakeLists.txt
index 51d49006f57ff..b61ed8c457635 100644
--- a/clang/unittests/Sema/CMakeLists.txt
+++ b/clang/unittests/Sema/CMakeLists.txt
@@ -1,6 +1,7 @@
-# There are only a small number of tests here,
-# allow running them without building all of
-# AllClangUnitTests.
+# SemaTests are distinct to enable fast incremental builds.
+# Merging it into AllClangTests would result in one less
+# large statically linked binary, but separating it out is
+# the right tradeoff today.
 add_distinct_clang_unittest(SemaTests
   ExternalSemaSourceTest.cpp
   CodeCompleteTest.cpp

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to