https://github.com/zyn0217 approved this pull request.

LGTM, but please wait for other reviewers as the change is really large.

> The user expectation is that getAs only removes top level sugar nodes, 
> leaving all the type sugar on the returned node

So suppose there are really some users who wanted the previous behavior, what 
should they do? getAs + desugar?

https://github.com/llvm/llvm-project/pull/155028
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to