https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/155046
Like other functions which results in abort, treat asm brk instruction as
trivial.
>From 9d3e26d1ef48d87d9a98969f74a2363c5039fe04 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa <rn...@webkit.org>
Date: Fri, 22 Aug 2025 15:57:45 -0700
Subject: [PATCH] [WebKit checkers] Treat asm brk as trivial
Like other functions which results in abort, treat asm brk instruction as
trivial.
---
.../Checkers/WebKit/PtrTypesSemantics.cpp | 7 ++++++
.../WebKit/trivial-code-check-asm-brk.cpp | 22 +++++++++++++++++++
2 files changed, 29 insertions(+)
create mode 100644
clang/test/Analysis/Checkers/WebKit/trivial-code-check-asm-brk.cpp
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
b/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
index 36c12582a5787..93ffc58b1055e 100644
--- a/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
@@ -666,6 +666,13 @@ class TrivialFunctionAnalysisVisitor
return IsFunctionTrivial(Callee);
}
+ bool VisitGCCAsmStmt(const GCCAsmStmt *AS) {
+ auto *Asm = AS->getAsmString();
+ if (!Asm)
+ return false;
+ return Asm->getString() == "brk #0xc471";
+ }
+
bool
VisitSubstNonTypeTemplateParmExpr(const SubstNonTypeTemplateParmExpr *E) {
// Non-type template paramter is compile time constant and trivial.
diff --git a/clang/test/Analysis/Checkers/WebKit/trivial-code-check-asm-brk.cpp
b/clang/test/Analysis/Checkers/WebKit/trivial-code-check-asm-brk.cpp
new file mode 100644
index 0000000000000..de98c77eb7347
--- /dev/null
+++ b/clang/test/Analysis/Checkers/WebKit/trivial-code-check-asm-brk.cpp
@@ -0,0 +1,22 @@
+// RUN: %clang_analyze_cc1 -triple arm-darwin
-analyzer-checker=alpha.webkit.UncountedCallArgsChecker -verify %s
+// expected-no-diagnostics
+
+void crash()
+{
+ __asm__ volatile ("brk #0xc471");
+ __builtin_unreachable();
+}
+
+class SomeObj {
+public:
+ void ref();
+ void deref();
+
+ void someWork() { crash(); }
+};
+
+SomeObj* provide();
+
+void doSomeWork() {
+ provide()->someWork();
+}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
