steakhal wrote: One more comment. Please don't use force-pushes on GitHub. That ruins the review experience. Use merges instead, and never break your commit history chain.
Another remark would be to add the commit hash to the reply comment where you say that something was fixed. That way the reviewer can easily click on the commit and verify that yes, indeed it was fixed in the right way. https://github.com/llvm/llvm-project/pull/152751 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
