================ @@ -26,6 +28,98 @@ static AsmFlavor inferFlavor(const CIRGenModule &cgm, const AsmStmt &s) { return isa<MSAsmStmt>(&s) ? AsmFlavor::x86_intel : gnuAsmFlavor; } +// FIXME(cir): This should be a common helper between CIRGen ---------------- el-ev wrote:
What about `addVariableConstraints`? It doesn't doesn't belong in `TargetInfo.h` because of the dependency on `clang/AST/Expr.h` and `clang/AST/Stmt.h`. And it would require a callback for error reporting as the module differs (`CodeGenModule` vs `CIRGenModule`). I recommend keeping it as is. https://github.com/llvm/llvm-project/pull/154014 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits