================ @@ -3410,9 +3418,36 @@ static void AddQualifierToCompletionString(CodeCompletionBuilder &Result, Result.AddTextChunk(Result.getAllocator().CopyString(PrintedNNS)); } +// Sets the function qualifiers completion string by inspecting the explicit +// object +static void AddCXXExplicitObjectFunctionTypeQualsToCompletionString( ---------------- HighCommander4 wrote:
This is a nice touch! One minor comment: could we refactor this to reuse code between this function, and the rest of `AddFunctionTypeQualsToCompletionString`? (That way, the "Handle single qualifiers without copying" optimization would apply here as well.) https://github.com/llvm/llvm-project/pull/154041 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits