================
@@ -11003,8 +11003,9 @@ void ASTReader::diagnoseOdrViolations() {
}
void ASTReader::StartedDeserializing() {
- if (++NumCurrentElementsDeserializing == 1 && ReadTimer.get())
- ReadTimer->startTimer();
+ if (llvm::Timer *T = ReadTimer.get();
+ ++NumCurrentElementsDeserializing == 1 && T && !T->isRunning())
+ T->startTimer();
----------------
alanzhao1 wrote:
`check-clang` and `check-clang-tools` produces 67 failures with this change:
```
Failed Tests (67):
Clang :: CXX/expr/expr.unary/expr.unary.noexcept/cg.cpp
Clang :: CXX/module/basic/basic.def.odr/p4.cppm
Clang :: CodeGen/pch-dllexport.cpp
Clang :: Headers/opencl-c-header.cl
Clang :: Headers/xmmintrin.c
Clang :: Modules/ExtDebugInfo.cpp
Clang :: Modules/codegen-flags.test
Clang :: Modules/codegen-opt.test
Clang :: Modules/codegen.test
Clang :: Modules/compare-objc-interface.m
Clang :: Modules/compare-objc-protocol.m
Clang :: Modules/compare-record.c
Clang :: Modules/concept.cppm
Clang :: Modules/cxx-irgen.cpp
Clang :: Modules/cxx20-importing-function-bodies.cppm
Clang :: Modules/initializers.cpp
Clang :: Modules/inline-builtins.cppm
Clang :: Modules/irgen.c
Clang :: Modules/lambda-in-variable.cpp
Clang :: Modules/merge-deduced-return.cpp
Clang :: Modules/merge-using-decls.cpp
Clang :: Modules/method_pool.m
Clang :: Modules/no-eager-load.cppm
Clang :: Modules/odr.cpp
Clang :: Modules/odr_hash-blocks.cpp
Clang :: Modules/odr_hash-enum.c
Clang :: Modules/odr_hash-gnu.cpp
Clang :: Modules/odr_hash-vector.cpp
Clang :: Modules/odr_hash.cl
Clang :: Modules/odr_hash.cpp
Clang :: Modules/odr_hash.mm
Clang :: Modules/pch-used.m
Clang :: Modules/polluted-operator.cppm
Clang :: Modules/pr120277-2.cpp
Clang :: Modules/pr120277.cppm
Clang :: Modules/pr61783.cppm
Clang :: Modules/pr76638.cppm
Clang :: Modules/pr93497.cppm
Clang :: Modules/redecl-ivars.m
Clang :: Modules/skip-odr-check-in-gmf.cppm
Clang :: Modules/templates.mm
Clang :: Modules/var-templates.cpp
Clang :: OpenMP/declare_variant_device_kind_codegen.cpp
Clang :: OpenMP/declare_variant_implementation_vendor_codegen.cpp
Clang :: OpenMP/declare_variant_mixed_codegen.cpp
Clang :: OpenMP/target_codegen.cpp
Clang :: OpenMP/target_firstprivate_codegen.cpp
Clang :: OpenMP/target_ompx_dyn_cgroup_mem_codegen.cpp
Clang :: OpenMP/target_parallel_codegen.cpp
Clang :: OpenMP/target_parallel_for_codegen.cpp
Clang :: OpenMP/target_parallel_for_simd_codegen.cpp
Clang :: OpenMP/target_parallel_if_codegen.cpp
Clang :: OpenMP/target_parallel_num_threads_codegen.cpp
Clang :: OpenMP/target_simd_codegen.cpp
Clang :: OpenMP/target_teams_codegen.cpp
Clang :: OpenMP/target_teams_distribute_codegen.cpp
Clang :: OpenMP/target_teams_distribute_simd_codegen.cpp
Clang :: OpenMP/target_teams_num_teams_codegen.cpp
Clang :: OpenMP/target_teams_thread_limit_codegen.cpp
Clang :: PCH/arc-blocks.mm
Clang :: PCH/codegen.cpp
Clang :: PCH/cxx1y-deduced-return-type.cpp
Clang :: PCH/decl-in-prototype.c
Clang :: PCH/non-trivial-c-compound-literal.m
Clang :: PCH/objc_literals.m
Clang :: PCH/race-condition.cpp
Clang :: SemaSYCL/sycl-kernel-entry-point-attr-kernel-name-module.cpp
Testing Time: 41.68s
Total Discovered Tests: 72250
Skipped : 10 (0.01%)
Unsupported : 4519 (6.25%)
Passed : 67626 (93.60%)
Expectedly Failed: 28 (0.04%)
Failed : 67 (0.09%)
```
https://github.com/llvm/llvm-project/pull/154231
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
