================
@@ -252,11 +252,11 @@ class CIRBaseBuilderTy : public mlir::OpBuilder {
   [[nodiscard]] cir::GlobalOp createGlobal(mlir::ModuleOp mlirModule,
                                            mlir::Location loc,
                                            mlir::StringRef name,
-                                           mlir::Type type,
+                                           mlir::Type type, bool isConstant,
                                            cir::GlobalLinkageKind linkage) {
     mlir::OpBuilder::InsertionGuard guard(*this);
     setInsertionPointToStart(mlirModule.getBody());
-    return create<cir::GlobalOp>(loc, name, type, linkage);
+    return create<cir::GlobalOp>(loc, name, type, isConstant, linkage);
----------------
andykaylor wrote:

```suggestion
    return cir::GlobalOp::create(*this, loc, name, type, isConstant, linkage);
```
Since you're modifying this code, let's bring it into conformance with the new 
idiom.

https://github.com/llvm/llvm-project/pull/154359
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to