usx95 wrote: This does introduce an extra layer of orchestration but** I like the current approach**. The `FactGeneratorVisitor` can now safely assume that all sub expressions must have been visited and does not have to case-by-case handle it during each Visit* methods. I think this becomes more and more important as we begin to handle more expression types.
> I guess the complexity here is an inevitable consequence of our CFGs being > just an overlay on top of the AST and it is not entirely clear when should we > use one or the other for traversals because it depends on what we are > processing. +1 https://github.com/llvm/llvm-project/pull/153661 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
